Remove unnecessary lval domain special cases #1031
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #998. This fixes the crash on Concrat's brubeck benchmark.
Since address domain keeps them in different buckets anyway, these special cases are no longer needed. By removing them, the the issue of bucket keys conflicting due to these overrides is fixed. The identity of offsets is thus completely standard and can be derived.
This requires a small fix in the evaluation of pointer equalities, which previously used
VD.equal.VD.equalis not appropriate for semantic equality and is replaced with actual evaluation. A check in 21-casts/01-via_ptr, which checkedVD.equal {f[def_exc:0]} {f[def_exc:0].x}, broke because the elements are no longer equal due to the offset equality handling such special case.EDIT: sv-benchmarks runs show no difference in results or performance.