Gobpie uses location ranges provided by Goblint #12 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of trying to find where to end a notification by finding the first ';', GobPie now uses line and column end positions from the JSON output provided by Goblint. Additonally, the Positions of AnalysisResults get the sourcfile information from JSON instead of using the file that the analysis was stared on as sourcefile, because the JSON output has results for several different files, not only the one that trigerred the analysis.
sim642
reviewed
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to find where to end a notification by finding the first ';', GobPie now uses line and column end positions from the JSON output provided by Goblint.
Additionally, the Positions of AnalysisResults get the source file information from JSON instead of using the file that the analysis was stared on as source file because the JSON output has results for several different files, not only the one that triggered the analysis.
Needs to wait until goblint/analyzer #449 is merged.