Skip to content

web/elements: fix dual select without sortBy (cherry-pick #14977) #14979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BeryJu merged 1 commit into from
Jun 9, 2025
Merged

web/elements: fix dual select without sortBy (cherry-pick #14977) #14979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/src/elements/ak-dual-select/ak-dual-select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ import {
} from "./types.js";

function localeComparator(a: DualSelectPair, b: DualSelectPair) {
const aSortBy = a[2];
const bSortBy = b[2];
const aSortBy = a[2] || a[0];
const bSortBy = b[2] || a[0];

return aSortBy.localeCompare(bSortBy);
}
Expand Down
2 changes: 1 addition & 1 deletion web/src/elements/ak-dual-select/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export type DualSelectPair<T = unknown> = [
/**
* A string to sort by. If not provided, the key will be used.
*/
sortBy: string,
sortBy?: string,
/**
* A local mapping of the key to the object. This is used by some specific apps.
*
Expand Down
Loading