Skip to content

root: revert install_id changes#13020

Closed
rissson wants to merge 2 commits into
mainfrom
revert-install-id-changes
Closed

root: revert install_id changes#13020
rissson wants to merge 2 commits into
mainfrom
revert-install-id-changes

Conversation

@rissson
Copy link
Copy Markdown
Member

@rissson rissson commented Feb 13, 2025

Details

#13018 and #13006 are breaking, respectively, the install_id retrieval code and the CI. Reverting until we can find a proper solution


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@rissson rissson self-assigned this Feb 13, 2025
@rissson rissson requested a review from a team as a code owner February 13, 2025 16:29
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 13, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 7222796
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67ae1dde24084800087f6228

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 13, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 7222796
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67ae1ddf67eedf0008f08e0e

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (5904fae) to head (7222796).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13020      +/-   ##
==========================================
- Coverage   92.68%   92.59%   -0.10%     
==========================================
  Files         785      785              
  Lines       39623    39623              
==========================================
- Hits        36724    36687      -37     
- Misses       2899     2936      +37     
Flag Coverage Δ
e2e 47.28% <100.00%> (-0.50%) ⬇️
integration 24.54% <100.00%> (-0.01%) ⬇️
unit 90.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson
Copy link
Copy Markdown
Member Author

rissson commented Feb 13, 2025

#13022 is the solution

@rissson rissson closed this Feb 13, 2025
@rissson rissson deleted the revert-install-id-changes branch February 13, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant