Skip to content

root: correctly use correct schema for install_id #13018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BeryJu merged 2 commits into from
Feb 13, 2025
Merged

root: correctly use correct schema for install_id #13018

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
193a43a
root: correctly use correct schema for install_id
BeryJu Feb 13, 2025
e6977f2
format
BeryJu Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions authentik/root/install_id.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@

from authentik.lib.config import CONFIG

QUERY = """SELECT id FROM %s.authentik_install_id ORDER BY id LIMIT 1;"""
# We need to string format the query as tables and schemas can't be set by parameters
# not a security issue as the config value is set by the person installing authentik
# which also has postgres credentials etc
QUERY = """SELECT id FROM {}.authentik_install_id ORDER BY id LIMIT 1;""".format( # nosec
CONFIG.get("postgresql.default_schema")
)


@lru_cache
Expand All @@ -20,7 +25,7 @@ def get_install_id() -> str:
if settings.TEST:
return str(uuid4())
with connection.cursor() as cursor:
cursor.execute(QUERY, (CONFIG.get("postgresql.default_schema")))
cursor.execute(QUERY)
return cursor.fetchone()[0]


Expand All @@ -40,5 +45,5 @@ def get_install_id_raw():
sslkey=CONFIG.get("postgresql.sslkey"),
)
cursor = conn.cursor()
cursor.execute(QUERY, params=(CONFIG.get("postgresql.default_schema")))
cursor.execute(QUERY)
return cursor.fetchone()[0]