Skip to content

root: fix ssl settings for read replicas not being applied#12341

Merged
BeryJu merged 3 commits into
mainfrom
root/fix-pg-config-ssl-read-replica
Dec 12, 2024
Merged

root: fix ssl settings for read replicas not being applied#12341
BeryJu merged 3 commits into
mainfrom
root/fix-pg-config-ssl-read-replica

Conversation

@BeryJu
Copy link
Copy Markdown
Member

@BeryJu BeryJu commented Dec 12, 2024

Details

Follow up to #12180


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner December 12, 2024 16:51
@BeryJu
Copy link
Copy Markdown
Member Author

BeryJu commented Dec 12, 2024

/cherry-pick version-2024.10

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 12, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit a31cbe3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/675b1609df2c9800082a6503
😎 Deploy Preview https://deploy-preview-12341--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 12, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit a31cbe3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/675b1609cf2360000842f392

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 97.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.64%. Comparing base (c3555c7) to head (a31cbe3).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/lib/config.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12341      +/-   ##
==========================================
- Coverage   92.67%   92.64%   -0.04%     
==========================================
  Files         762      762              
  Lines       38252    38324      +72     
==========================================
+ Hits        35451    35506      +55     
- Misses       2801     2818      +17     
Flag Coverage Δ
e2e 48.83% <12.22%> (-0.23%) ⬇️
integration 24.69% <12.22%> (-0.04%) ⬇️
unit 90.26% <97.77%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 12, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-a31cbe3288f6bfe43d86cb17810d3ecf47d3f9db
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-a31cbe3288f6bfe43d86cb17810d3ecf47d3f9db-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-a31cbe3288f6bfe43d86cb17810d3ecf47d3f9db

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-a31cbe3288f6bfe43d86cb17810d3ecf47d3f9db-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 9a5effa into main Dec 12, 2024
@BeryJu BeryJu deleted the root/fix-pg-config-ssl-read-replica branch December 12, 2024 17:53
gcp-cherry-pick-bot Bot pushed a commit that referenced this pull request Dec 12, 2024
* root: fix ssl settings for read replicas not being applied

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* slight refactor

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Dec 12, 2024
#12341) (#12345)

root: fix ssl settings for read replicas not being applied (#12341)

* root: fix ssl settings for read replicas not being applied



* fix



* slight refactor



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants