456-fix-error-codes

[Ankaa19]

add errors to facility functions #456

Error handling code was created for the following functions:

• stumpless_get_facility_string
• stumpless_get_facility_enum
• stumpless_get_facility_enum_from_buffer

[goatshriek]

It's unclear to me why you've chosen to implement a file-specific error code instead of using the error code functionality already present in the library.

Please rework this change to use the library's existing error code functions (defined in src/error.c and used extensively throughout the project).

[Ankaa19]

hello, I change my pull request according to your comment. Is it ok?

[goatshriek]

Please remove the .idea folder from the commits, and add tests as described in the original issue.

[Ankaa19]

Hello,
sorry for delay. I was sick. I added tests according to the requirements in the issue to the pull request.
Please check it and if it's ok could you merge it?

[goatshriek]

You'll need to get the tests passing, of course. From the one that I looked at you'll probably need to do a few rounds of tweaks and rebuilds.