Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket targets may fail to bind to local socket when not provided #54

Closed
goatshriek opened this issue Mar 23, 2019 · 0 comments
Closed
Assignees
Labels
bug something is broken or missing

Comments

@goatshriek
Copy link
Owner

goatshriek commented Mar 23, 2019

Socket targets can be opened with a local socket name provided, but this may also be set to NULL, in which case a local socket is generated (see the documentation of stumpless_open_socket_target for details). However, this socket is always the same, which means that if a target is not properly closed the local socket will remain. Successive targets will be unable to open, as they will attempt to bind to the same socket name and will fail as it already exists.

This could be fixed by adding some number of retries to the local socket name, ideally randomized so that the names are not linear. The solution should also be documented in the documentation, and of course tests for the fixed functionality should be created as well.

@goatshriek goatshriek added bug something is broken or missing help wanted external contributations encouraged labels Mar 23, 2019
goatshriek added a commit that referenced this issue May 19, 2020
@goatshriek goatshriek removed the help wanted external contributations encouraged label Jul 15, 2020
@goatshriek goatshriek self-assigned this Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is broken or missing
Projects
None yet
Development

No branches or pull requests

1 participant