Skip to content

Conversation

ArthurFreeb
Copy link

@ArthurFreeb ArthurFreeb commented Sep 28, 2025

Combined v2 Fixes: Enums, Null Safety, and ID Alias

This PR combines the changes from three separate PRs to provide a single, comprehensive update that addresses multiple v2 filter improvements:

Included Changes

1. Enum Support (from #99)

  • Added support for enum values in filter queries
  • Allows both quoted and unquoted enum symbols to be parsed and evaluated correctly
  • Introduces a new EnumSymbolLiteral AST node
  • Updates parser and evaluator logic to handle enums
  • Extends test coverage to verify enum filtering functionality

2. Null Safety Improvements (from #100)

  • Enhanced null safety in the filter evaluator
  • Improved handling of nullable properties throughout the evaluation chain
  • Better error handling for null reference scenarios

3. ID Alias Fix (from #101)

  • Fixed issues with property aliases, particularly for ID fields
  • Improved property mapping to handle both standard and aliased property names correctly
  • Ensures proper resolution of property paths when aliases are used

Related PRs

This PR combines the following individual PRs:

Testing

All changes have been tested together and include comprehensive test coverage for:

  • Enum filtering with various status values
  • Null safety scenarios with nested properties
  • Property alias resolution, especially for ID fields

The individual PRs remain available if you prefer to review and merge them separately.

@Jamess-Lucass
Copy link
Member

Going to close this PR in favour of multiple smaller ones that tackle each feature individually. As the Id alias feature is not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants