feat: impl XL_PLATFORM #1648
Open
feat: impl XL_PLATFORM #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blooym
added a commit
to goatcorp/XIVLauncher.Core
that referenced
this pull request
Nov 28, 2024
XL_PLATFORM for windows was implemented via a seperate PR at goatcorp/FFXIVQuickLauncher#1648. XoM uses their own fork of XLCommon that isn't the one in this repository, so it's fine to assume its only Linux here I think, I don't know anyone using this on a Mac
This is mostly incase XoM pulls from upstream ever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested at goatcorp/XIVLauncher.Core#77 for Dalamud here https://github.com/goatcorp/Dalamud/blob/f16a3367c0fad56b4ce760439823122fc6845580/Dalamud/Utility/Util.cs#L527-L534
Not implemented for Unix since that code here is unused as XLCore ripped it out for its own use.