Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RetainerSales Initial Evaluation #5251

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

RetainerSales Initial Evaluation #5251

wants to merge 4 commits into from

Conversation

Populo
Copy link

@Populo Populo commented Dec 19, 2024

Simple plugin to mark retainers that have sold things while you were offline because i can never remember the numbers for sale. Please let me know if something isn't up to par!

image

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 19, 2024 •
edited
Loading

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@Populo Populo marked this pull request as ready for review December 19, 2024 15:29
@reiichi001
Copy link
Contributor

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 20, 2024 •
edited
Loading

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
😰 RetainerSales [testing-live] 44dffad Build system error: Only HTTPS repository URLs ending in .git are supported
Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. build failed This plugin failed to build. labels Dec 20, 2024
@bleatbot
Copy link
Collaborator

bleatbot commented Dec 20, 2024 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ RetainerSales [testing-live] 44dffad v1.0.0.0 - Repo (New plugin)
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-mid Diff for this PR is mid-sized. and removed build failed This plugin failed to build. labels Dec 20, 2024
@bleatbot
Copy link
Collaborator

bleatbot commented Dec 20, 2024 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ RetainerSales [testing-live] 298641e v1.0.0.1 - Repo (New plugin)
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 20, 2024 •
edited
Loading

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
😰 RetainerSales [testing-live] 55c3b77 Build system error: could not read from remote repository
Show log - Review

@bleatbot bleatbot added build failed This plugin failed to build. and removed size-mid Diff for this PR is mid-sized. labels Dec 20, 2024
@Populo
Copy link
Author

Populo commented Dec 20, 2024

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ RetainerSales [testing-live] 55c3b77 v1.0.0.1 - Repo (New plugin)
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-mid Diff for this PR is mid-sized. and removed build failed This plugin failed to build. labels Dec 20, 2024
@reiichi001 reiichi001 added completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. pending-testing This plugin still needs to be tested. completed-rules-compliance This plugin is compliant with all rules. labels Dec 21, 2024
@Populo
Copy link
Author

Populo commented Dec 21, 2024

If I may offer advice for testing (how I did it). Open the retainer list to generate the dictionary in the config file and change the numbers there. Have to close the game and reopen to get it to read the changed values tho, couldn’t make it read the file every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ackwell ackwell ackwell approved these changes

Assignees

@goaaats goaaats

Labels
completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. completed-rules-compliance This plugin is compliant with all rules. new plugin This is a new plugin. pending-testing This plugin still needs to be tested. size-mid Diff for this PR is mid-sized.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Populo @bleatbot @reiichi001 @ackwell @goaaats