Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Add ContactsTracker #5217

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Testing] Add ContactsTracker #5217

wants to merge 4 commits into from

Conversation

DueDine
Copy link

@DueDine DueDine commented Dec 11, 2024

This is my first plugin, please let me know if there are any issues.


This plugin records the party composition at the end of each duty, similar to the in-game Contacts function. It also logs the entry method (e.g., Just select it or Duty Roulette), duration, jobs, and levels. Edge cases like disconnection, rejoining, and early termination are somewhat handled. However, I couldn’t extensively test certain scenarios like Solo Duties in MSQ or being kicked etc.

My current objective is to log duty data, which will help address user interest in metrics such as the average time spent on any roulette or the percentage of specific duties, like Crystal Tower in Alliance Raids.

Any Feedback is appreciate!

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 11, 2024

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@bleatbot bleatbot enabled auto-merge (squash) December 11, 2024 16:59
@reiichi001
Copy link
Contributor

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 12, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ ContactsTracker [testing-live] 5fb5d20 v0.0.1.0 - Repo (New plugin)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet CsvHelper 33.0.1 goaaats
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. size-large Diff for this PR is large. labels Dec 12, 2024
auto-merge was automatically disabled December 12, 2024 07:45

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 12, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ ContactsTracker [testing-live] 8c510aa v0.0.1.0 - Repo (New plugin)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet CsvHelper 33.0.1 goaaats
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 12, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ ContactsTracker [testing-live] c069e65 v0.0.2.0 - Repo (New plugin)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet CsvHelper 33.0.1 goaaats
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ ContactsTracker [testing-live] 1c6cc8d v0.1.0.0 - Repo (New plugin)
9 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet CsvHelper 33.0.1 goaaats
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@reiichi001 reiichi001 added pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. completed-rules-compliance This plugin is compliant with all rules. labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed-rules-compliance This plugin is compliant with all rules. new plugin This is a new plugin. pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants