Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] ShopItemRevealer 1.0.0.0 #5204

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nathanctech
Copy link

New plugin that pops a window on supported vendors (currently only beast tribes) showing items the player doesn't have access to and are hidden from the shop, along with a reason why.

@bleatbot bleatbot enabled auto-merge (squash) December 9, 2024 07:29
auto-merge was automatically disabled December 9, 2024 07:36

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 9, 2024

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@philpax
Copy link
Contributor

philpax commented Dec 9, 2024

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 9, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
😰 ShopItemRevealer [testing-live] 8e74739 Build system error: remote authentication required but no callback set
Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. build failed This plugin failed to build. labels Dec 9, 2024
@philpax
Copy link
Contributor

philpax commented Dec 9, 2024

Hi, it looks like your repository isn't accessible to the public?

@nathanctech
Copy link
Author

My bad! I totally forgot to swap it to public...

@nathanctech
Copy link
Author

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 9, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ ShopItemRevealer [testing-live] 8e74739 v1.0.0.0 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-large Diff for this PR is large. and removed build failed This plugin failed to build. labels Dec 9, 2024
@bleatbot
Copy link
Collaborator

bleatbot commented Dec 15, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ ShopItemRevealer [testing-live] 8e74739 v1.0.0.0 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ ShopItemRevealer [testing-live] 6ac075b v1.0.0.0 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@reiichi001 reiichi001 added pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. completed-rules-compliance This plugin is compliant with all rules. labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed-rules-compliance This plugin is compliant with all rules. new plugin This is a new plugin. pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants