Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] HUDLayoutHelper v1.0.0 #5193

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Mary-Usagi
Copy link

@Mary-Usagi Mary-Usagi commented Dec 8, 2024

My first plugin, so I'm probably doing some inefficient stuff in there. >.<

The plugin adds some QoL features to the native HUD Layout editor:

  • ctrl+z/ctrl+y for undoing/redoing the movement of hud elements
  • ctrl+c/ctrl+v for copying and pasting the position of elements
  • ctrl+r to show lines that help with alignment of hud elements

:)

Screenshot

alignment_lines

@bleatbot bleatbot enabled auto-merge (squash) December 8, 2024 06:51
auto-merge was automatically disabled December 8, 2024 15:18

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 8, 2024

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@reiichi001
Copy link
Contributor

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 8, 2024

Outdated attempt

⚠️ No builds attempted! This probably means that your owners property is misconfigured.

Name Commit Status
👽 HUDLayoutHelper [testing-live] 9620732 Not your plugin
Show log - Review

@bleatbot bleatbot added the new plugin This is a new plugin. label Dec 8, 2024
@reiichi001
Copy link
Contributor

You'll want to set the owner in your manifest.toml to Mary-Usagi so it matches your github username. I should be able to approve builds then.

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 8, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ HUDLayoutHelper [testing-live] 9620732 v0.0.0.1 - Repo (New plugin)
15 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet System.Numerics.Vectors 4.5.0 reiichi001
NuGet System.Runtime.Numerics 4.3.0 reiichi001
NuGet YamlDotNet 16.0.0 reiichi001
NuGet Microsoft.NETCore.Platforms 1.1.0 goaaats
NuGet Microsoft.NETCore.Targets 1.1.0 goaaats
NuGet System.Globalization 4.3.0 goaaats
NuGet System.IO 4.3.0 goaaats
NuGet System.Reflection 4.3.0 goaaats
NuGet System.Reflection.Primitives 4.3.0 goaaats
NuGet System.Resources.ResourceManager 4.3.0 goaaats
NuGet System.Runtime 4.3.0 goaaats
NuGet System.Runtime.Extensions 4.3.0 goaaats
NuGet System.Text.Encoding 4.3.0 goaaats
2 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added the size-large Diff for this PR is large. label Dec 8, 2024
@bleatbot
Copy link
Collaborator

bleatbot commented Dec 8, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ HUDLayoutHelper [testing-live] c58c754 v0.0.0.1 - Repo (New plugin)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet System.Numerics.Vectors 4.5.0 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@Mary-Usagi
Copy link
Author

Mary-Usagi commented Dec 11, 2024

Would it be okay if I update the main branch of my repo with a more organized project structure (and also update the commit hash here)? Or would that interfere with any reviews that are already being done? :D I've only moved files around, so no changes to any logic

@reiichi001
Copy link
Contributor

That will reset the code review, but I don't think anyone's gotten to that for this one, so it should be fine

@bleatbot
Copy link
Collaborator

bleatbot commented Dec 11, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ HUDLayoutHelper [testing-live] 0f6886e v0.0.0.1 - Repo (New plugin)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet System.Numerics.Vectors 4.5.0 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

fix badly positioned help window
@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ HUDLayoutHelper [testing-live] e383f68 v0.0.0.1 - Repo (New plugin)
2 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet System.Numerics.Vectors 4.5.0 reiichi001
1 hidden need (known safe NuGet packages).
Show log - Review

@reiichi001 reiichi001 added pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. completed-rules-compliance This plugin is compliant with all rules. labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed-rules-compliance This plugin is compliant with all rules. new plugin This is a new plugin. pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants