Build adjustments for code annotation #2155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfcomp
reviewed
Dec 24, 2024
.github/workflows/main.yml
Outdated
| on: | ||
| push: | ||
| pull_request: | ||
| types: [opened] |
There was a problem hiding this comment.
This will cause subsequent builds to not trigger for PRs. This should not be the case and the default types for pull_request is opened, syncronize, reopened which all handle different cases with pushes to the pull request for commits and if a pull request is opened again after closing. Best is to revert this change as you want it to build for each time something happens to the commit tree for the PR.
There was a problem hiding this comment.
Hmm, when testing on my fork the push trigger was firing whenever I made a commit to my draft PR. That could've been something on my end - I'll revert this portion though just to be safe.
nathanctech
force-pushed
the
ci_annotate
branch
from
7b82c94 to
95d7f9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overrides Nuke's log handling and removes the problematic formatting the default analyzers were unable to process as well as improving the build flow to reduce duplicate warnings (and thus annotations). Building and testing have merged into a single step, and warnings are suppressed from the test rebuild since they're just refired from the initial build process anyway.
In addition, I adjusted the workflow so pushes to an existing pull request won't trigger both the push and PR builds to occur in some cases which also contributed to the warning duplication. In the end, file changes now have code-level annotations!