Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI cleanup and changes to ImGuiHelpers #2147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

UI cleanup and changes to ImGuiHelpers #2147

wants to merge 2 commits into from

Conversation

Infiziert90
Copy link
Contributor

@Infiziert90 Infiziert90 commented Dec 17, 2024 •
edited
Loading

  • Removes most uses of formatted imgui function

ImGuiHelpers Class:

  • Changes the existing SafeTextWrapped implementation from .Replace() to what ImGui does internally
  • Adds two new "Safe" function SafeTextDisabled and SafeTextColored

@Infiziert90
- Remove formatted imgui function usage
df1a9cf 
- Change existing safe function
- Add new safe function
@Infiziert90 Infiziert90 changed the title - Remove formatted imgui function usage UI cleanup and changes to ImGuiHelpers Dec 17, 2024
@Infiziert90 Infiziert90 marked this pull request as ready for review December 17, 2024 13:31
@Infiziert90 Infiziert90 requested a review from a team as a code owner December 17, 2024 13:31
@KazWolfe
Copy link
Member

Yet another argument for just forking ImGui.NET and locking our API surface to *Unformatted only.

@Infiziert90
Copy link
Contributor Author

Added SafeSetTooltip, this replaces the last formatted function which was missing.
Important to note is that this function does not 100% replicate the original behaviour, as ImRaii doesn't offer support for discarding previous Tooltips, nor do we have access to this flag in our bindings currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Infiziert90 @KazWolfe