Issue #3162557 by tBKoT, Kingdutch: Update delete notification condition #1965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate update hook for removing not used notifications.
tbkot
added
type: bug
ribel
added
the
needs work: maintainer input
Contributor
|
Hey @ronaldtebrake, |
ribel
removed
the
status: needs review
Contributor
|
Hi @ribel, nice work looks good to me also in 8.5! :) |
ribel
removed
the
needs work: maintainer input
ribel
changed the title
ribel
deleted the
feature/3162557-notification-are-not-actualy-deleted
branch
ribel
pushed a commit
that referenced
this pull request
Sep 9, 2020
…ion. Create update hook for removing not used notifications. (#1965)
ribel
pushed a commit
that referenced
this pull request
Sep 9, 2020
…ion. Create update hook for removing not used notifications. (#1965)
ribel
added
the
backport: verified
Contributor
|
🍒 picked to 8.x and 9.x |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is an error in \Drupal\activity_creator\ActivityNotifications::deleteNotificationsByIds. On line 260 of ActivityNotifications.php the line ->condition('aid', $activity_ids) is used, where $activity_ids is an array. However, the default comparison operator for condition is = which causes issues in the query, resulting in unremoved activities.
Solution
Issue tracker
https://www.drupal.org/project/social/issues/3162557