Skip to content

Fix rmap set debug log cardinality #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Fix rmap set debug log cardinality #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a64c240
Fix log cardinality in the set debug log for rmap
douglaswth Jun 4, 2024
596b379
Fix test for rmap set debug log as well
douglaswth Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rmap/map.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ func (sm *Map) run() {
sm.logger.Debug("deleted", "key", key)
default:
sm.content[key] = val
sm.logger.Debug("set", key, val)
sm.logger.Debug("set", "key", key, "val", val)
}
select {
case sm.ichan <- struct{}{}:
Expand Down
2 changes: 1 addition & 1 deletion rmap/map_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ func TestLogs(t *testing.T) {

// Check that the logs contain the expected messages
assert.Contains(t, buf.String(), `joined`)
assert.Contains(t, buf.String(), `foo=bar`)
assert.Contains(t, buf.String(), `key=foo val=bar`)
assert.Contains(t, buf.String(), `msg=deleted key=foo`)
assert.Contains(t, buf.String(), `reset`)
assert.Contains(t, buf.String(), `stopped`)
Expand Down