Skip to content

Conversation

tchssk
Copy link
Member

@tchssk tchssk commented Sep 23, 2025

No description provided.

@tchssk tchssk marked this pull request as ready for review September 23, 2025 00:43
@tchssk tchssk requested a review from Copilot September 23, 2025 00:43
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes client method generation for services without result types in the testing/codegen package. The changes ensure that methods without results properly handle endpoint calls by discarding the return value and returning only errors.

  • Adds test data for services with and without result types to validate the generation
  • Updates client method templates to properly handle methods without results
  • Creates comprehensive tests to verify correct client generation

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
testing/codegen/testdata/dsls.go Adds DSL definitions for services with and without result types
testing/codegen/testdata/code.go Adds expected generated code for both service types
testing/codegen/templates/client_methods.go.tpl Fixes template to properly handle methods without results
testing/codegen/clients_test.go Adds comprehensive tests for client generation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@raphael
Copy link
Member

raphael commented Oct 10, 2025

This is great, thank you! (and apologies for the delay)

@raphael raphael merged commit c63381e into v3 Oct 10, 2025
5 checks passed
@raphael raphael deleted the testing-client-methods-without-result branch October 10, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants