Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for 7.1 #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updates for 7.1 #29

wants to merge 2 commits into from

Conversation

reiichi001
Copy link

  • Moved to Dalamud.Net.Sdk
  • Fixed Sheet references on config window
  • Fixed log spam (an open PR/request from 2020)

- Moved to Dalamud.Net.Sdk
- Fixed Sheet references on config window
- Fixed log spam (an open PR/request from 2020)
@Felys1998 Felys1998 mentioned this pull request Nov 23, 2024
@weyway
Copy link

weyway commented Nov 23, 2024

Good catch on the log. I've had it running on dev for me these last days, with most of the same changes.
I just didn't PR this because I wasn't confident enough since I can't test much of it, as the main character profile I have has many more things that don't translate to a low level alt easily, since this covers all the things on your main's profile.

@RubyLepus
Copy link

  • Moved to Dalamud.Net.Sdk
  • Fixed Sheet references on config window
  • Fixed log spam (an open PR/request from 2020)

Hello! I love this plugin and it helps me so much with all my characters, thank you so much for it. I've been curious, are you guys updating it for 7.1? Did something bad happen?

@reiichi001
Copy link
Author

No, it's just dependent on @goaaats not being super busy. The plugin itself isn't abandoned, but I don't currently feel like co-opting another Goat plugin (like Owofy, RichPresence, and DiscordBridge). I suppose if Goat doesn't mind, I can push from my fork until later as a co-maintainer since this plugin is more or less feature complete and doesn't have room for feature enhancements.

@RubyLepus
Copy link

RubyLepus commented Dec 12, 2024

No, it's just dependent on @goaaats not being super busy. The plugin itself isn't abandoned, but I don't currently feel like co-opting another Goat plugin (like Owofy, RichPresence, and DiscordBridge). I suppose if Goat doesn't mind, I can push from my fork until later as a co-maintainer since this plugin is more or less feature complete and doesn't have room for feature enhancements.

Oh, i see! It's a relief to know that the plugin is still going on and it's just people being busy, it's all good, life happens sometimes! I hope things will smooth out soon; I will be looking forward for the update in the future or hopefully soon if you figure out something :D
Thank you so much for your quick answer and all the hardwork. I really appreciate it!

Adds Franz as a maintainer in json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants