v3: Use map[string] for maps when merged keys are also strings #693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The map type is
map[string]
when all keys in a map are strings. This adds an additional check to ensure thatmap[string]
is also the map type used for merges, providing the map to be merged also only contains string keys.This was reported by @nervo here: #139 (comment)
For example:
At the moment returns a
map[interface{}]interface{}
, when ideally, it should be amap[string]interface{}
because bothbar
andfoo
contain only string keys. This PR fixes this.