This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Feature (v2): set the default line length to infinity (-1) #571
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@niemeyer can we get this merged in? |
|
Done! |
|
@laverya Thanks for the PR. |
|
Is there any chance of this becoming a release soon @niemeyer? Or do we need to wait longer to see if objections are raised? |
|
Wish conceded! I think we've waited enough. I'm also thinking of tagging v3 in the next few days, and switching over to it as the main branch. Blockers are almost over. |
marckhouzam
added a commit
to VilledeMontreal/cobra
that referenced
this pull request
Oct 16, 2020
yaml.v2 contains a breaking change from go-yaml/yaml#571 yaml.v2 2.2.8 does not have that change and also addresses the CVE that was behind the move to yaml.v2 2.3.0. This commit reverts to using yaml.v2 2.2.8 Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
marckhouzam
added a commit
to VilledeMontreal/cobra
that referenced
this pull request
Oct 16, 2020
yaml.v2 contains a breaking change from go-yaml/yaml#571 yaml.v2 2.2.8 does not have that change and also addresses the CVE that was behind the move to yaml.v2 2.3.0. This commit reverts to using yaml.v2 2.2.8 Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
jpmcb
pushed a commit
to spf13/cobra
that referenced
this pull request
Oct 18, 2020
yaml.v2 contains a breaking change from go-yaml/yaml#571 yaml.v2 2.2.8 does not have that change and also addresses the CVE that was behind the move to yaml.v2 2.3.0. This commit reverts to using yaml.v2 2.2.8 Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
dims
added a commit
to dims/yaml-1
that referenced
this pull request
Nov 12, 2020
This reverts commit 0b1645d. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
This was referenced Apr 1, 2022
Closed
muscliary
pushed a commit
to muscliary/cobra
that referenced
this pull request
Sep 12, 2023
yaml.v2 contains a breaking change from go-yaml/yaml#571 yaml.v2 2.2.8 does not have that change and also addresses the CVE that was behind the move to yaml.v2 2.3.0. This commit reverts to using yaml.v2 2.2.8 Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as suggested here: #166 (comment)