Fix typed nil hook support #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR @adriansmares ! Would you mind rebasing your branch to resolve the conflicts? I'll take a look at this PR later this week. |
Member
|
@adriansmares, apologies for dropping the ball on this. We've made some changes around nil value handling in #42 and #45. Can you check how your changes related to those? I suspect they are related (although I didn't have time to properly check). |
Author
|
Hi @sagikazarmark, It seems that the linked PRs did indeed fix my long standing issue. After a rebase the test case passes without any changes to Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References mitchellh#278
Typed
nils which are the result of a type decoding hook seem to result in incorrect decoding behavior. Specifically, thenilis turned into an actual value due to the way thenilcheck works, instead of preserving thenil. Previously we were returning just untypednils but ever since mitchellh#205 this seems to no longer be supported while chaining multiple hooks.I've added a test which reproduces this issue, and a possible fix. Please also take a look at the comments in the original PR.