feat(schedule)!: show schedule errors and nest object #795
Conversation
|
whats the plan for adding the other changes made in go-vela/server#1108 like nested repos? |
I'll attach the nested Schedule and types migration changes to this PR |
|
|
||
| msgRow = | ||
| tr [ class "error-data", Util.testAttribute "schedules-error" ] | ||
| [ td [ attribute "colspan" "6" ] |
There was a problem hiding this comment.
is this "6" supposed to match the number of columns?
if so maybe we can make the value dynamic depending on the number of headers?
| [ td [ attribute "colspan" "6" ] | |
| [ td [ attribute "colspan" (String.fromInt <| List.length tableHeaders) ] |
There was a problem hiding this comment.
im just nitpicking. i realize now that its hardcoded in some places, so whatever.
but i was thinking about this spot when i wrote that:
https://github.com/go-vela/ui/blob/main/src/elm/Components/Table.elm#L131
There was a problem hiding this comment.
I took that snippet from viewHookError in src/elm/Pages/Org_/Repo_/Hooks.elm
wsan3
changed the title
Good suggestion. I'll create one. |
Description
Whenever a user has a YAML bug in their pipeline, or any other build-breaking error that short-circuits pipeline execution, they can usually find these error in the Audit tab, where we populate the hook with the error message.
This is currently not available for schedules. Instead, the error is just logged.
Desired View
Related
go-vela/community#872