Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Bot API 5.2, other small fixes #443

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Updates for Bot API 5.2, other small fixes #443

merged 1 commit into from
Jun 8, 2021

Conversation

Syfaro
Copy link
Member

@Syfaro Syfaro commented Apr 26, 2021

Changes:

  • Changes for Bot API 5.2
  • Add omitempty to some fields that should have it

Other notes:

  • The provider_data field is documented as 'A JSON-serialized data about the invoice, which will be shared with the payment provider.' Is there some way to make this clearer with library types? It's currently a string field which seems odd (but that's what it says in the Bot API docs).
  • The docs updated to say record_audio and upload_audio should have been record_voice and upload_voice, is there any better way to handle this than commenting that the previous values are deprecated?

@Syfaro Syfaro added the telegram update Telegram changed something label Apr 26, 2021
@Syfaro Syfaro requested a review from tjhorner April 26, 2021 16:10
Copy link
Collaborator

@tjhorner tjhorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tjhorner
Copy link
Collaborator

  • Is there some way to make this clearer with library types? It's currently a string field which seems odd (but that's what it says in the Bot API docs).

I think having a simple "See the payment API docs for more details" would suffice here. I assume if people need this field they know what they're doing anyway.

  • The docs updated to say record_audio and upload_audio should have been record_voice and upload_voice, is there any better way to handle this than commenting that the previous values are deprecated?

I think this is the best way to go. I guess we could update the old constants to reflect the new values Telegram expects going forward, in case they ever remove support for the old values.

@Syfaro Syfaro merged commit 2c2c95a into develop Jun 8, 2021
@Syfaro Syfaro deleted the bot-api-5.2 branch June 8, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
telegram update Telegram changed something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants