fix: publish nightly draft and title #2358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with the nightly release configuration by creating a separate GoReleaser configuration file for nightly builds. The main issues addressed are preventing nightly releases from being published as drafts and ensuring correct release titles.
- Created a dedicated
.goreleaser-nightly.ymlconfiguration file for nightly releases - Removed nightly-specific configuration from the main
.goreleaser.ymlfile - Updated GitHub Actions workflows to use appropriate configurations and flags
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.goreleaser.yml |
Removed release draft setting and nightly configuration to clean up main release config |
.goreleaser-nightly.yml |
New dedicated configuration for nightly releases with proper title template and settings |
.github/workflows/release.yml |
Added --draft flag to ensure regular releases are published as drafts |
.github/workflows/release-nightly.yml |
Updated to use the new nightly-specific configuration file |
vmaerten
force-pushed
the
fix/publish-nightly
branch
2 times, most recently
from
2782cf2 to
5703aa1
Compare
vmaerten
force-pushed
the
fix/publish-nightly
branch
from
5703aa1 to
ce5fe81
Compare
vmaerten
force-pushed
the
fix/publish-nightly
branch
from
bd068b1 to
baef05d
Compare
vmaerten
force-pushed
the
fix/publish-nightly
branch
from
baef05d to
c6f30e8
Compare
pd93
approved these changes
Aug 7, 2025
andreynering
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nightly release was published as draft
Also the title was incorrect.
I've made the choice use another yaml config to not impact our "real" release workflow