Fix install script for armv5/6/7. #2291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
reviewed
Jun 9, 2025
There was a problem hiding this comment.
Thank you!
FYI: We originally used https://github.com/goreleaser/godownloader to generate these scripts, but the tool got deprecated, so I think we needed to update the file manually for fixes.
@trulede Can you replicate these changes on website/static/install.sh? We have two copies because originally people fetched from the repo, but nowadays we instruct users to fetch from the website (http://taskfile.dev/install.sh).
andreynering
added
area: releasing
|
@andreynering yes, I've pushed that change. FWIW you don't need godownloader (or similar), the script is good enough in its current state. |
andreynering
approved these changes
Jun 9, 2025
andreynering
added a commit
that referenced
this pull request
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install-task.sh script was converting "armv7*" to "arm" in function
uname_arch(), checking that "arm" value inuname_arch_check(), and then finally using a case condition based on "armv7" in functionget_binaries(). So of course the download would fail.GO Arch only includes linux/arm variant.
Solution is to fix the
get_binaries()function.fixes #1516
Download tested on PI aarch64, script modified with hardcoded arch as "arm7l". Expected version of task was downloaded.