-
-
Notifications
You must be signed in to change notification settings - Fork 725
fix(watcher): fix some v3.43.x regressions #2271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a8faba1
to
de7ecf1
Compare
Test results: #2199 (comment) |
The problem persist. I use task to run my webserver
|
Hey @noahfraiture, I could not reproduce.
|
Sure, I have the same issue with this code
And this task
I'm on Linux NixOs. I built the task binary from the branch watcher/fix-some-regressions-2202-2199 |
de7ecf1
to
8d61133
Compare
8d61133
to
02332bb
Compare
@noahfraiture I wasn't able to reproduce your issue and the program being killed right away, but after some testing I found some other issues related to the watcher. For now, I'll merge this PR as is as it fixes a couple of issues, but I'll see what we can do from now on. |
I seems to be fixed for now |
Some testing is highly appreciated! Let me know if this fixes the issues you're having or not.
/cc @davidkuridza @noahfraiture @pot-code @SheGe