New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: requires allowed values works with dynamic var #2033

Open

vmaerten wants to merge 1 commit into main from fix/allowed-values-with-dynamic-var

Member

vmaerten commented Feb 2, 2025 •

edited

Loading

Fixes Requires returns inconsistent results for dynamic variables depending upon whether or not enum is specified #2032

I've split the check into two methods:

One for the requires which should be evaluated before the task being compilated (this allows for a well-formed message when using this variable in a template, see: Template function breaks the "requires" feature #1950 / requires not evaluated before dynamic variables #1970 )
One for the allowed values, which works with dynamic variables.


          fix: requires allowed values works with dynamic var

c7152b1

vmaerten marked this pull request as ready for review

February 2, 2025 11:22

vmaerten requested review from andreynering and pd93

February 2, 2025 11:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet