Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: evaluate requires before compiled task #1962

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix: evaluate requires before compiled task #1962

merged 1 commit into from
Dec 30, 2024

Conversation

vmaerten
Copy link
Member

Fixes :

Two thing here :

  • The template should be evaluated (in CompiledTask) only after verifying the required variables.
  • skipFingerprint should not bypass the required variable checks.

@vmaerten vmaerten linked an issue Dec 15, 2024 that may be closed by this pull request
Template function breaks the "requires" feature #1950
Closed
@vmaerten vmaerten marked this pull request as ready for review December 15, 2024 18:23
@vmaerten vmaerten merged commit d64df3f into main Dec 30, 2024
14 checks passed
@vmaerten vmaerten deleted the fix/evaluate-require-before-compile branch December 30, 2024 09:15
vmaerten added a commit that referenced this pull request Dec 30, 2024
@vmaerten
chore: changelog for #1962
1bda388
@vmaerten vmaerten mentioned this pull request Dec 30, 2024
Closed
@pd93 pd93 linked an issue Dec 30, 2024 that may be closed by this pull request
requires not evaluated before dynamic variables #1970
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pd93 pd93 pd93 approved these changes

@andreynering andreynering Awaiting requested review from andreynering

Assignees
No one assigned
Labels
area: requires
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

requires not evaluated before dynamic variables Template function breaks the "requires" feature
3 participants
@vmaerten @pd93 @andreynering