feat: iterators #1798
Merged
feat: iterators #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pd93
force-pushed
the
iterators
branch
2 times, most recently
from
021b258 to
48788c9
Compare
pd93
force-pushed
the
iterators
branch
2 times, most recently
from
9322d62 to
6d79903
Compare
pd93
requested review from
vmaerten and
andreynering
and removed request for
vmaerten
vmaerten
approved these changes
Feb 22, 2025
taskfile/ast/graph.go
Outdated
| @@ -116,14 +116,14 @@ func (tfg *TaskfileGraph) Merge() (*Taskfile, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| _ = rootVertex.Taskfile.Tasks.Range(func(name string, task *Task) error { | |||
| // TODO: I don't think this is necessary anymore | |||
There was a problem hiding this comment.
Do you want to resolve / check this TODO in another PR ?
There was a problem hiding this comment.
This was a note to myself and I just forgot to come back to it. Task.Task is populated when the Tasks parent type is decoded so this is no longer needed. I've rebased the PR and removed this section.
pd93
added a commit
that referenced
this pull request
Feb 22, 2025
pd93
added
the
area: package api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1797 and #1972 which adds support for iterators in our codebase. This tidies up a lot of code (We have a lot of
Rangefunctions) and makes control-flow a bit easier in loops.I have also slightly refactored the
sortpackage to be slightly more generic and use a function type rather than an interface. The interface was not necessary and increased the code complexity.This is a Go 1.23 feature which requires a bump to our minimum Go version hence the draft PR (Obviously the tests will fail as Go 1.24 does not currently exist).Done.