fix: --version when a version is provided with -ldflags #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaerten
force-pushed
the
fix/version-check-devrel
branch
from
8ddf5ec to
3118154
Compare
vmaerten
force-pushed
the
fix/version-check-devrel
branch
from
3118154 to
2658710
Compare
vmaerten
force-pushed
the
fix/version-check-devrel
branch
from
2658710 to
467cb9a
Compare
andreynering
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We went a bit too far when refactoring this. Some people build Task theirself and provide the version with ldflags. But in our implementation we override the version.
fixes #1709
I used this command to check :
go build -o "task" -ldflags "-s -w -X github.com/go-task/task/v3/internal/version.version=3.38.0" ./cmd/tasklike they do in Homebrew (https://github.com/Homebrew/homebrew-core/blob/e71417b07f53e9ea7c79974dd6f6c2297d9a9a1c/Formula/g/go-task.rb#L23-L32)