-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose task's exit code to env var 'DEFER_EXIT_CODE' #1673
Conversation
Update documentation for DEFER_EXIT_CODE
23e29a8
to
9be807e
Compare
Merge from main
Revert "remove package-lock.json" This reverts commit 2409637. remove package-lock
97a6ebf
to
4b91a54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dorimon-1. Thanks for your pull request, it is much appreciated!
I'm requesting changes EXIT_CODE
should be a regular variable and not an environment variable. This would make it consistent with the other special variables.
Hi, thanks for your comment. |
@andreynering @pd93 any chance to get this merged? |
Also fixed conflicts and updated docs with the current standard |
Hey @dorimon-1! There were further changes required for this to work as desired. I did those changes on #1762 and just merged it. Basically, we neede to make that variable as scoped as possible, i.e., available only to that specific |
Issue: #1484
Exposes environment variable DEFER_EXIT_CODE once a task is finished, to allow you to use it in defer statements.
In case there was an error (exit code != 0), it wont be overridden by a successful task, but it will be overridden when a different task fails with a different code.