add connection timeout function

[button-chen]

Hello, the current implementation of Dial does not have a timeout , in some cases we should need to specify a connection timeout. So I added a DialWithContext function.

I tried to write it like this before:

c, err := net.Dial(network, addr)
c.SetReadDeadline(...)   // set
Connect(c, ...)
c.SetReadDeadline(...)   // recover

but this is not guaranteed to be correct, however, because the code in the Connect function: go readLoop(c, reader) -->

f, err := reader.Read()
if err ! = nil {
    close(c.readCh)
    return
}

may be executed before recover SetReadDeadline, And just in time for the deadline causing read coroutines to exit.

thank you

[button-chen]

Hello, can you take a look at this pr @worg

[worg]

can we add a couple of tests for this? specially covering the deadline from context

[worg]

isn't this the same as the check on line 165? I think you meant to use !ok
also why SetReadDeadline and not SetDeadline?

[worg]

additionaly, can we move this one above so it's next to the other if

[button-chen]

The problem to be solved here is that after the stomp client sends the stomp protocol connect message, the stomp server does not reply due to some reasons, such as: stomp server resources are insufficient stomp client message, and the stomp client will block forever. The use of SetReadDeadline here is correct because we want reader.Read() to time out instead of blocking forever, Calling SetReadDeadline again at line 173 with the argument time.Time{} restores net.Conn's read blocking behavior because we don't want it to affect subsequent data interactions. thank you

[button-chen]

Similar writing can be found in the standard library http, src/net/http/server.go can find many similar implementation methods, such as go1.23.1 （src/net/http/server.go）:

[button-chen]

can we add a couple of tests for this? specially covering the deadline from context

ok