Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ack must be sent on MESSAGE / id on ACK #120

Closed
worg opened this issue Mar 23, 2022 · 0 comments · Fixed by #121
Closed

ack must be sent on MESSAGE / id on ACK #120

worg opened this issue Mar 23, 2022 · 0 comments · Fixed by #121

Comments

@worg
Copy link
Collaborator

worg commented Mar 23, 2022 •
edited
Loading

The change in #118 didn't consider the case for MESSAGE frames, as per the spec, the ACK frames must include id header but MESSAGE frames must use ack when explicit acknowledgment is required.

reported by @dselim in #118 (comment)_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: wrong header sent for explicit acknowledgment go-stomp/stomp
1 participant
@worg