fix incorrect header for message id in ACK frames #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://stomp.github.io/stomp-specification-1.2.html#ACK > The ACK frame MUST include an id header matching the ack header of the MESSAGE being acknowledged. So, instead of "ack" header ACK frame must include "id" header
|
LGTM |
dselim
reviewed
Mar 22, 2022
| } else { | ||
| f.Header.Set(frame.Ack, messageId) | ||
| f.Header.Set(frame.Id, messageId) |
There was a problem hiding this comment.
It is my understanding that only ACK frames should use the id header. This MESSAGE frame should still use ack header. https://stomp.github.io/stomp-specification-1.2.html#MESSAGE
Or am I mistaken ?
There was a problem hiding this comment.
@dselim you're right, sorry my bad 😔
|
you're correct, working on a fix
…On Tue, 22 Mar 2022, 05:13 Dorian Selimovic, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In server/client/conn.go
<#118 (comment)>:
> } else {
- f.Header.Set(frame.Ack, messageId)
+ f.Header.Set(frame.Id, messageId)
@Delorus <https://github.com/Delorus> @worg <https://github.com/worg>
It is my understanding that only ACK frames should use the id header.
This MESSAGE frame should still use ack header.
https://stomp.github.io/stomp-specification-1.2.html#MESSAGE
Or am I mistaken ?
—
Reply to this email directly, view it on GitHub
<#118 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFE4G2KSLQTBATDFASOQSDVBGTM7ANCNFSM5RFRPEXQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://stomp.github.io/stomp-specification-1.2.html#ACK
So, instead of "ack" header ACK frame must include "id" header