fix for enum and set field type to column type identifying

[jennifersp]

Description

The patch will allow identifying of ENUM and SET column types.

Related issue: #1517

Checklist

• Code compiles correctly
• Created tests which fail without the change (if possible)
• All tests passing
• Extended the README / documentation, if necessary
• Added myself / the copyright holder to the AUTHORS file

Summary by CodeRabbit

• Documentation

  • Updated the list of contributors and organizations.

• Bug Fixes

  • Improved the logic for determining field types in the database to correctly identify "ENUM" and "SET" types based on specific flags.

[coderabbitai]

Walkthrough

The overall change involves updating the go-sql-driver/mysql package to correctly identify and handle ENUM and SET column types in MySQL. This is achieved by modifying the logic within a method to check for specific flags and return the appropriate type name, addressing an issue where these types were incorrectly returned as CHAR.

Changes

File Path	Change Summary
fields.go	Modified typeDatabaseName method to correctly identify ENUM and SET types based on flags.
driver_test.go	Added test cases for "enum" and "set" column types in the TestRowsColumnTypes function.

Related issues

• Issue go-sql-driver/mysql#1517: The changes in this PR seem to address the objectives of this issue by updating the fields.go file to correctly recognize ENUM and SET column types, which is the key objective mentioned in the issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment from CodeRabbit.
• You can also chat with CodeRabbit bot directly around the specific lines of code or files in the PR by tagging @coderabbitai in a new comment.
• You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 98d7289 and fd55af3.

Files selected for processing (2)

• AUTHORS (4 hunks)
• fields.go (1 hunks)

Additional comments: 5

AUTHORS (4)

• 21-27: The addition of Brian Hendriks to the list of individual contributors is correctly placed in alphabetical order.

• 55-61: The addition of Jennifer Purevsuren to the list of individual contributors is correctly placed in alphabetical order.

• 117-129: The addition of Dolthub Inc. to the list of organizations is correctly placed in alphabetical order.

• 137-139: No issues found with the existing entries in the list of organizations.

fields.go (1)

• 77-87: The changes to the typeDatabaseName method correctly implement the logic to return "ENUM" or "SET" based on the flagEnum and flagSet flags. This aligns with the PR objective to handle ENUM and SET types properly.

[methane]

LGTM.

[coveralls]

coverage: 82.704% (-0.02%) from 82.719%
when pulling 8e7cd6d on jennifersp:master
into 98d7289 on go-sql-driver:master.

[methane]

Would you add some test cases for these column types?

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between fd55af3 and 8e7cd6d.

Files selected for processing (1)

• driver_test.go (1 hunks)

Additional comments: 1

driver_test.go (1)

• 3007-3008: The addition of ENUM and SET types to the TestRowsColumnTypes function in driver_test.go is correctly implemented. The test cases are well-formed and should effectively test the driver's ability to handle these MySQL-specific column types.

[jennifersp]

Added tests for ENUM and SET column types. PTAL.