Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support of Go 1.12 #1211

Merged
merged 3 commits into from
May 18, 2021
Merged

Drop support of Go 1.12 #1211

merged 3 commits into from
May 18, 2021

Conversation

shogo82148
Copy link
Contributor

@shogo82148 shogo82148 commented May 15, 2021 •
edited
Loading

Description

Go 1.12 is no longer supported.
related with #1210

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

methane
methane previously approved these changes May 16, 2021
View reviewed changes
@methane
Copy link
Member

methane commented May 16, 2021

Could you update this line too?

mysql/go.mod

Line 3 in bcc459a

go 1.10

@Jogo27
Copy link

Jogo27 commented May 16, 2021

Maybe it's the right time to clean up the nulltime files too.

@shogo82148 shogo82148 requested a review from methane May 17, 2021 21:12
@shogo82148
Copy link
Contributor Author

Thank you for reviewing. I fixed.

@shogo82148
Copy link
Contributor Author

Thanks!

@shogo82148 shogo82148 merged commit b36cd86 into go-sql-driver:master May 18, 2021
@shogo82148 shogo82148 deleted the drop-support-of-go1.12 branch May 18, 2021 01:33
@shogo82148 shogo82148 mentioned this pull request May 18, 2021
Merged
5 tasks
@alimoli alimoli mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shogo82148 @methane @Jogo27