Support ok packet represents eof #1153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tz70s
force-pushed
the
support-deprecated-eof-packet
branch
from
476b93a
to
ea32d9f
Compare
tz70s
force-pushed
the
support-deprecated-eof-packet
branch
from
ea32d9f
to
667a05a
Compare
tz70s
commented
Sep 5, 2020
| if err = mc.readUntilEOF(); err != nil { | ||
| return nil, err | ||
| } | ||
| } |
There was a problem hiding this comment.
Seems MySQL behavior isn't consistent to the documentation here: https://dev.mysql.com/doc/internals/en/com-stmt-prepare-response.html
However, Maria DB follows this specification.
IMO this feature should be held until there's a clear solution to be compatible with supported vendors.
There was a problem hiding this comment.
Can I continue your excellent work? Does this problem be solved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor fixes from #962, ensuring backward compatibility on legacy EOF format.
Checklist
This change is