Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate mysql.NullTime #960

Closed
julienschmidt opened this issue Apr 30, 2019 · 3 comments · Fixed by #1144
Closed

Deprecate mysql.NullTime #960

julienschmidt opened this issue Apr 30, 2019 · 3 comments · Fixed by #1144
Labels
documentation
Milestone
v1.8.0

Comments

@julienschmidt
Copy link
Member

database/sql will have a NullTime type from Go1.13 onward, which should be used instead: golang/go#30305
@julienschmidt julienschmidt added this to the v1.6.0 milestone Apr 30, 2019
@dolmen
Copy link
Contributor

dolmen commented Sep 4, 2019

Or better: make mysql.NullTime an alias to database/sql.NullTime when compiling on Go 1.13+.

I will submit a PR to implement this solution.

@dolmen dolmen mentioned this issue Sep 4, 2019
Open
@dolmen
Copy link
Contributor

dolmen commented Sep 4, 2019

Well, the Scan method is specific to MySQL, so we have to keep it. I will change to wrap database/sql.NullTime.

@dolmen dolmen mentioned this issue Sep 4, 2019
Merged
5 tasks
@smtakeda smtakeda mentioned this issue Nov 16, 2019
Closed
@shogo82148 shogo82148 mentioned this issue Jan 5, 2020
Closed
5 tasks
@methane methane mentioned this issue May 26, 2020
Merged
5 tasks
@julienschmidt julienschmidt modified the milestones: v1.6.0, v1.7.0 Jun 1, 2020
@AlaNDGT
Copy link

AlaNDGT commented Jun 18, 2020

Will rows.ColumnTypes() (first value from db.Query()) return sql.NullTime instead of mysql.NullTime too?

This was referenced Aug 13, 2020
Merged
Merged
johejo added a commit to johejo/xo that referenced this issue Apr 15, 2021
@johejo
Update go-sql-driver/mysql to v1.6.0
d214edc 
- Replace mysql.NullTime with sql.NullTime (go-sql-driver/mysql#960)
@johejo johejo mentioned this issue Apr 15, 2021
Closed
johejo added a commit to johejo/xo that referenced this issue Apr 16, 2021
@johejo
Replace mysql.NullTime with sql.NullTime
e331c9e 
See go-sql-driver/mysql#960
Close xo#237
@johejo johejo mentioned this issue Apr 16, 2021
Closed
@zihengCat zihengCat mentioned this issue Jul 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging a pull request may close this issue.

Add deprecated message to NullTime shogo82148/mysql
3 participants
@dolmen @julienschmidt @AlaNDGT