ui: don't run bindata when using embed #801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1aafe76c1-PR-801
💛 - Coveralls |
Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](axios/axios@v0.21.1...v0.21.2) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
ARolek
force-pushed
the
ui-build-script-improvement
branch
2 times, most recently
from
3d9f26a
to
f15ff8f
Compare
* The UI is built by callinig go generate. This was not being done during release so the built in viewer was not available in the compiled binary. * Fix Windows npm compile bug for ui throwing the error "error Delete `␍` prettier/prettier" * Added nodejs to Docker container to compile the UI
ARolek
force-pushed
the
ui-build-script-improvement
branch
from
f15ff8f
to
bdb6bb8
Compare
|
This has been merged into master. |
|
@ear7h for some reason it appears this did not get properly merged. I'm re-opening and will figure out what's going on. |
|
I ended up dropping go-bindata entirely in this PR: #843. Closing in favor of that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this required multiple files and there was another go file in the directory I moved it to its own directory.