Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: assign a version number at compile time #202

Merged
merged 1 commit into from
Mar 19, 2023
Merged

feat: assign a version number at compile time #202

merged 1 commit into from
Mar 19, 2023

Conversation

1379
Copy link
Contributor

@1379 1379 commented Mar 18, 2023

Use compile time assignment capabilities to set the version number to avoid changing the code every time a new version is released

#187

@1379 1379 assigned jakezhu9 and unassigned jakezhu9 Mar 18, 2023
@1379 1379 requested a review from jakezhu9 March 18, 2023 12:26
@1379
Copy link
Contributor Author

1379 commented Mar 18, 2023

@jakezhu9 request to your review

jakezhu9
jakezhu9 approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@jakezhu9 jakezhu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1379 1379 merged commit 0ec15ed into master Mar 19, 2023
@1379 1379 deleted the feat/version branch March 19, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakezhu9 jakezhu9 jakezhu9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1379 @jakezhu9