docs: Updated compile/build information for macOS and Linux #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the information of building from source to match the latest go 1.20+ and Mac OS X steps. Confirmed on Linux (Arch).
Update Installation.md
fmartingr
reviewed
Aug 6, 2023
| @@ -30,10 +30,11 @@ On Windows, you can simply set the `PATH` by using the advanced system settings. | |||
|
|
|||
| ## Building From Source | |||
|
|
|||
| Shiori uses Go module so make sure you have version of `go >= 1.14.1` installed, then run: | |||
| Shiori uses Go module so make sure you have version of `go >= 1.14.1` installed. In the cloned git repository run: | |||
|
|
|||
| ``` | |||
| go get -u -v github.com/go-shiori/shiori | |||
There was a problem hiding this comment.
I think it's better to just switch this command to go install github.com/go-shiori/shiori, right? That will build and install the command from source directly without cloning the repository (which is what the old documentaton wanted to achieve I guess).
What do you think?
fmartingr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the information on how to build the source on Mac OS X and Linux.