Enhance buildCurlRequest for unit test

[yaziedda]

Hacktoberfest

[jeevatkm]

@yaziedda Thanks for creating PR.

I can't see an enhancement in the util_curl.go; if you're interested in adding a unit test, it would be appreciated.

Can you please revert the change in util_curl.go?

[yaziedda]

@yaziedda Thanks for creating PR.

I can't see an enhancement in the util_curl.go; if you're interested in adding a unit test, it would be appreciated.

Can you please revert the change in util_curl.go?

Thanks for the feedback @jeevatkm , but for add unit test need improve util_curl.go because function buildCurlRequest not give consistent result like double space at assign domain. Example :

Expected :
curl -X GET -H 'Authorization: Bearer token' -H 'Content-Type: application/json' http://example.com

Actual from existing util_curl.go
curl -X GET -H 'Authorization: Bearer token' -H 'Content-Type: application/json' http://example.com

Left : My enhance code
Right : From existing code

[jeevatkm]

@yaziedda I see, thanks for the details.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (bea44b7) to head (87c933d).
Report is 1 commits behind head on v2.

Additional details and impacted files

@@            Coverage Diff             @@
##               v2     #884      +/-   ##
==========================================
+ Coverage   96.15%   96.59%   +0.43%     
==========================================
  Files          14       14              
  Lines        1821     1821              
==========================================
+ Hits         1751     1759       +8     
+ Misses         46       39       -7     
+ Partials       24       23       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jeevatkm]

@yaziedda, I just noticed this. Can you please move the unit test to this file curl_cmd_test.go?

[yaziedda]

@yaziedda, I just noticed this. Can you please move the unit test to this file curl_cmd_test.go?

@jeevatkm I’ve already changed it to curl_cmd_test.go.

[jeevatkm]

Thanks for correcting it @yaziedda

[yaziedda]

You're welcome, can we merge this PR @jeevatkm ?