New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not use errors.Join, just use custom error approach #863

Merged

jeevatkm merged 2 commits into v2 from do-not-use-errors-join

Sep 21, 2024

Member

jeevatkm commented Sep 21, 2024

As it turns out, errors.Join is not playing well with simple errors like errors.New or fmt.Errorf. For now, let's go with a custom error with Unwrap.


          fix: do not use errors.Join, just use custom error approach

19530bc

jeevatkm self-assigned this

codecov bot commented Sep 21, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.15%. Comparing base (5d33e1a) to head (33f6035).
Report is 1 commits behind head on v2.

Files with missing lines	Patch %	Lines
client.go	50.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               v2     #863      +/-   ##
==========================================
- Coverage   96.23%   96.15%   -0.09%     
==========================================
  Files          14       14              
  Lines        1808     1821      +13     
==========================================
+ Hits         1740     1751      +11     
- Misses         45       46       +1     
- Partials       23       24       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


          fix: do not use errors.Join, just use custom error approach

33f6035

jeevatkm merged commit ce7695b into v2

3 of 4 checks passed

jeevatkm deleted the do-not-use-errors-join branch

September 21, 2024 21:06

Michsior14 referenced this pull request in Michsior14/transmission-gluetun-port-update


          build(deps): update module github.com/go-resty/resty/v2 to v2.15.2 (#22)

00d094d

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/go-resty/resty/v2](https://github.com/go-resty/resty)
| `v2.15.1` -> `v2.15.2` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-resty%2fresty%2fv2/v2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-resty%2fresty%2fv2/v2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-resty%2fresty%2fv2/v2.15.1/v2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-resty%2fresty%2fv2/v2.15.1/v2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>go-resty/resty (github.com/go-resty/resty/v2)</summary>

###
[`v2.15.2`](https://github.com/go-resty/resty/releases/tag/v2.15.2)

[Compare
Source](https://github.com/go-resty/resty/compare/v2.15.1...v2.15.2)

### Release Notes

#### Bug Fixes

- fix: do not use `errors.Join`, just use custom error approach by
[@&#8203;jeevatkm](https://github.com/jeevatkm) in
[https://github.com/go-resty/resty/pull/863](https://github.com/go-resty/resty/pull/863)

#### Documentation

- release: version bump and readme update for v2.15.2 by
[@&#8203;jeevatkm](https://github.com/jeevatkm) in
[https://github.com/go-resty/resty/pull/864](https://github.com/go-resty/resty/pull/864)

**Full Changelog**:
go-resty/resty@v2.15.1...v2.15.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/Michsior14/transmission-gluetun-port-update).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet