Skip to content

Conversation

@jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented Oct 31, 2021

Merge this PR after PR #484
Closes #486

@jeevatkm jeevatkm added this to the v2.7.0 Milestone milestone Oct 31, 2021
@jeevatkm jeevatkm self-assigned this Oct 31, 2021
@jeevatkm jeevatkm requested a review from moorereason October 31, 2021 22:41
@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #485 (30fcfa3) into master (d837dfc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #485   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files          10       10           
  Lines        1328     1328           
=======================================
  Hits         1284     1284           
  Misses         26       26           
  Partials       18       18           
Impacted Files Coverage Δ
resty.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d837dfc...30fcfa3. Read the comment docs.

@jeevatkm
Copy link
Member Author

jeevatkm commented Nov 2, 2021

@moorereason readme updated!

Copy link
Contributor

@moorereason moorereason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeevatkm
Copy link
Member Author

jeevatkm commented Nov 4, 2021

Thanks @moorereason 👍

@jeevatkm jeevatkm merged commit 3d08b36 into master Nov 4, 2021
@jeevatkm jeevatkm deleted the for-v2.7.0-release branch November 4, 2021 05:22
hurracrane pushed a commit to Shopify/resty that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

README: explain that Client.JSONMarshal/JSONUnmarshal can be overloaded

3 participants