-
Notifications
You must be signed in to change notification settings - Fork 95
Improve some things around how errors are reported when parsing a file #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apologies for dropping the ball.
LGTM, modulo some tests that need to be fixed.
thanks for the PR.
Nice! Fixed the tests up. They pass locally now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
thanks for sticking with us.
could you send another PR against go-python/license adding yourself to the AUTHORS
and/or CONTRIBUTORS
file(s) ?
then I'll merge this one in.
thanks again.
there's one remaining error, though:
|
needs go-python/license#17 |
Signed-off-by: Sebastien Binet <[email protected]>
I took the liberty of fixing the last remaining error and pushing my changes, so I could merge this PR in :) thanks a lot. |
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=======================================
Coverage 73.22% 73.22%
=======================================
Files 72 72
Lines 11765 11765
=======================================
Hits 8615 8615
Misses 2568 2568
Partials 582 582
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh so sorry! I got distracted and forgot to get back to this one. Thanks for that :) |
no worries :) |
Given the malformed input "/Users/jpoole/gpython/test.py":
Before:
After