Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BREAKING): Change CIDRIPv4 validation #945

Merged
merged 2 commits into from
Oct 2, 2023
Merged

feat(BREAKING): Change CIDRIPv4 validation #945

merged 2 commits into from
Oct 2, 2023

Conversation

martinlehoux
Copy link
Contributor

Summary

Fixes Or Enhances

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@coveralls
Copy link

coveralls commented May 14, 2022 •
edited
Loading

Coverage Status

coverage: 73.849%. remained the same when pulling 95c81e6 on martinlehoux:master into 8d50f2f on go-playground:master.

@martinlehoux martinlehoux marked this pull request as ready for review July 31, 2022 19:48
@martinlehoux martinlehoux requested a review from a team as a code owner July 31, 2022 19:48
@martinlehoux
Copy link
Contributor Author

Hi @deankarn , is there anything I can do to push this forward?

@martinlehoux
Copy link
Contributor Author

Hi @deankarn is there anyway to have a status on this one? So I know if I take the time to rebase, or if this change is not useful

deankarn
deankarn previously approved these changes Oct 1, 2023
View reviewed changes
@deankarn
Copy link
Contributor

deankarn commented Oct 1, 2023

Hey @martinlehoux sorry for letting this one slip through the cracks.

yes I will try to merge tomorrow.

@deankarn deankarn merged commit 94a637a into go-playground:master Oct 2, 2023
10 checks passed
@mhristache mhristache mentioned this pull request Nov 20, 2023
Open
2 tasks
@yamamoto-febc yamamoto-febc mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

@hjwk hjwk hjwk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinlehoux @coveralls @deankarn @hjwk