Skip to content

Conversation

@0n1shi
Copy link
Contributor

@0n1shi 0n1shi commented Aug 14, 2021

Enhances

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

Change details:

  • Add DNS RFC 1035 label validation based on RFC 1035

@go-playground/validator-maintainers

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 75.11% when pulling 06ef82a on 0n1shi:dns_rfc1035 into ce34f36 on go-playground:master.

@0n1shi 0n1shi closed this Sep 15, 2021
@deankarn
Copy link
Contributor

Why close @0n1shi ?

@0n1shi
Copy link
Contributor Author

0n1shi commented Sep 15, 2021

Is this too niche ? only label.

I wanted to use this like below
https://github.com/kubernetes/kubernetes/blob/HEAD/staging/src/k8s.io/apimachinery/pkg/util/validation/validation.go#L219

for providing app hosting service on kubernetes.

@deankarn
Copy link
Contributor

The PR works for me. I just have very little time to merge and maintain recently.

@0n1shi
Copy link
Contributor Author

0n1shi commented Sep 16, 2021

Sorry for bothering you while you're busy.

I recreated the same PR below.
#833

You can close it if you dont need it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants