Merged
Conversation
zemzale
force-pushed
the
revert-e164-min-limit
branch
from
87d350a to
10841cb
Compare
Although the E164 spec technically would allow for numbers with only one digit after the country code, we used to expect atleast 7 digits, since that is what is way more practical. In fix for E164 to disallow leading 0 in country codes, we lowered said limit to 1 digit. This broke things for peoples as numbers like `123456` became valid. Reverting back to the original limit of 7 digits, is practical, and probably the expected behavior out of this validator.
zemzale
force-pushed
the
revert-e164-min-limit
branch
from
10841cb to
6975b54
Compare
nodivbyzero
approved these changes
Dec 23, 2025
deankarn
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Although the E164 spec technically would allow for numbers with only one
digit after the country code, we used to expect atleast 7 digits, since
that is what is way more practical.
In fix for E164 to disallow leading 0 in country codes, we lowered said
limit to 1 digit. This broke things for peoples as numbers like
123456became valid.
Reverting back to the original limit of 7 digits, is practical, and
probably the expected behavior out of this validator.
Related #1515
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers